Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Not all jsonparse errors are handled by JSONStream #136

Open
ataube opened this issue Jul 5, 2017 · 1 comment · May be fixed by #138
Open

Not all jsonparse errors are handled by JSONStream #136

ataube opened this issue Jul 5, 2017 · 1 comment · May be fixed by #138

Comments

@ataube
Copy link

ataube commented Jul 5, 2017

The underlying jsonparse lib triggers one specific error which is not handled by JSONStream:
Look here:
https://github.com/creationix/jsonparse/blob/master/jsonparse.js#L321

And here:
https://github.com/dominictarr/JSONStream/blob/master/index.js#L140

It would be helpful if JSONStream could also wrap this error as an Invalid JSON message to have a consistent error contract one can check for.
@dominictarr
Copy link
Owner

sure, I would be happy to merge this pull request!

@ataube ataube linked a pull request Jul 7, 2017 that will close this issue
Open
@juliangruber juliangruber mentioned this issue Nov 23, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle jsonparse errors consistently ataube/JSONStream
2 participants
@dominictarr @ataube