This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #136
I am not 100% sure if I like this. Overall the error checks are very fragile in case of
jsonparse
changing some wording, we would probably miss them.Also not this PR breaks code If someone relies on the unhandled error message structure.
We could add some test and and simulate all jsonparse errors to ensure every message gets wrapped correctly. What do you think?