Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

es.split generate a empty line for trailing newline #90

Closed
yinrong opened this issue Nov 24, 2015 · 4 comments
Closed

es.split generate a empty line for trailing newline #90

yinrong opened this issue Nov 24, 2015 · 4 comments

Comments

@yinrong
Copy link

yinrong commented Nov 24, 2015

es.split is mostly used for processing line by line, however we usually get an empty line at the end of the file. Please remove trailing newline.

@dominictarr
Copy link
Owner

use es.split({trailing: false})
see here for documentation: https://www.npmjs.com/package/split

On Tue, Nov 24, 2015 at 7:52 PM, yinrong notifications@github.com wrote:

es.split is mostly used for processing line by line, however we usually
get an empty line at the end of the file. Please remove trailing newline.


Reply to this email directly or view it on GitHub
#90.

@yinrong
Copy link
Author

yinrong commented Nov 25, 2015

I think event-stream's doc should have a link to split's doc.

@guiprav
Copy link

guiprav commented Dec 10, 2017

event-stream@3.3.4, the latest version on npm, depends on split@0.3, which doesn't implement the trailing option. split itself is at version 1.0.1. Why is this, and how can we fix it? (Edit: I've installed and used split directly instead of es.split; would be nice if event-stream was updated to use latest split, though!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@guiprav @dominictarr @yinrong and others