New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es.split generate a empty line for trailing newline #90

Closed
yinrong opened this Issue Nov 24, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@yinrong

yinrong commented Nov 24, 2015

es.split is mostly used for processing line by line, however we usually get an empty line at the end of the file. Please remove trailing newline.

@dominictarr

This comment has been minimized.

Owner

dominictarr commented Nov 24, 2015

use es.split({trailing: false})
see here for documentation: https://www.npmjs.com/package/split

On Tue, Nov 24, 2015 at 7:52 PM, yinrong notifications@github.com wrote:

es.split is mostly used for processing line by line, however we usually
get an empty line at the end of the file. Please remove trailing newline.


Reply to this email directly or view it on GitHub
#90.

@yinrong

This comment has been minimized.

yinrong commented Nov 25, 2015

I think event-stream's doc should have a link to split's doc.

@n2liquid

This comment has been minimized.

n2liquid commented Dec 10, 2017

event-stream@3.3.4, the latest version on npm, depends on split@0.3, which doesn't implement the trailing option. split itself is at version 1.0.1. Why is this, and how can we fix it? (Edit: I've installed and used split directly instead of es.split; would be nice if event-stream was updated to use latest split, though!)

@right9ctrl

This comment has been minimized.

Collaborator

right9ctrl commented Sep 5, 2018

split upgraded to 1.0.1

@right9ctrl right9ctrl closed this Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment