Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimist #55

Merged
merged 1 commit into from
Jul 25, 2015
Merged

update minimist #55

merged 1 commit into from
Jul 25, 2015

Conversation

ralphtheninja
Copy link
Contributor

rc is using an old version of minimist and I'd like to be able to use minimist aliases, e.g.

var minimist = require('minimist')

module.exports = require('rc')('myapp', {
  foo: 'foovalue',
  bar: 'barvalue'
}, minimist(process.argv, {
  alias: { foo: 'f', bar: 'b' }
}))

While I can always do this it's nice if rc uses the latest minimist so npm can dedupe properly whenever a dependant depends on both rc and minimist.

Alternatively I'd like to be able to somehow pass the aliases object into rc which in turn passes it to minimist.

@ralphtheninja
Copy link
Contributor Author

Basically it's the dedupe step I'm after :)

@dominictarr
Copy link
Owner

okay cool

dominictarr added a commit that referenced this pull request Jul 25, 2015
@dominictarr dominictarr merged commit 573c178 into dominictarr:master Jul 25, 2015
@dominictarr
Copy link
Owner

i decided that the correct thing to do is make this a minor change.
merged into 1.1.0

@ralphtheninja
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants