Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(notification-container): Remove unnecessary white space #204

Merged
merged 2 commits into from
Mar 11, 2021
Merged

style(notification-container): Remove unnecessary white space #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d567d
Fix class set on wrong element causing unnecessary white space
dominique-mueller Mar 11, 2021
4375b34
Fix unit tests
dominique-mueller Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/angular-notifier/src/lib/components/notifier-container.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<ul>
<li class="notifier__container-list" *ngFor="let notification of notifications; trackBy: identifyNotification">
<ul class="notifier__container-list">
<li class="notifier__container-list-item" *ngFor="let notification of notifications; trackBy: identifyNotification">
<notifier-notification [notification]="notification" (ready)="onNotificationReady($event)" (dismiss)="onNotificationDismiss($event)">
</notifier-notification>
</li>
Expand Down
22 changes: 11 additions & 11 deletions projects/angular-notifier/src/lib/components/notifier-container.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('Notifier Container Component', () => {
type: 'SHOW',
});
componentFixture.detectChanges();
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

expect(listElements.length).toBe(1);

Expand Down Expand Up @@ -353,7 +353,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

expect(listElements.length).toBe(0);
expect(mockNotificationComponent.hide).toHaveBeenCalled();
Expand Down Expand Up @@ -397,7 +397,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

expect(listElements.length).toBe(1);
expect(mockNotificationComponent.hide).not.toHaveBeenCalled();
Expand Down Expand Up @@ -454,7 +454,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -512,7 +512,7 @@ describe('Notifier Container Component', () => {
tick(testNotifierConfig.animations.hide.speed);
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -566,7 +566,7 @@ describe('Notifier Container Component', () => {
tick(testNotifierConfig.animations.hide.speed - <number>testNotifierConfig.animations.overlap);
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -607,7 +607,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges();

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 2;
expect(listElements.length).toBe(0);
Expand Down Expand Up @@ -665,7 +665,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -744,7 +744,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(1);
Expand Down Expand Up @@ -824,7 +824,7 @@ describe('Notifier Container Component', () => {
tick();
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(0);
Expand Down Expand Up @@ -876,7 +876,7 @@ describe('Notifier Container Component', () => {
tick(testNotifierConfig.animations.hide.speed + numberOfNotifications * <number>testNotifierConfig.animations.hide.offset);
componentFixture.detectChanges(); // Run a second change detection (to update the template)

const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list'));
const listElements: Array<DebugElement> = componentFixture.debugElement.queryAll(By.css('.notifier__container-list-item'));

const expectedCallTimes = 3;
expect(listElements.length).toBe(0);
Expand Down