Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose actionStream in Notifier Service #214

Merged
merged 1 commit into from Jul 13, 2021

Conversation

StepaZol
Copy link
Contributor

@StepaZol StepaZol commented Jul 3, 2021

Thanks for the package.
I would like to listen to the actions.
This will help me enable my handlers, such as playing sounds when a certain notification appears or finding out that the user has closed the notification without creating a custom template for notifications.

@StepaZol
Copy link
Contributor Author

StepaZol commented Jul 3, 2021

@dominique-mueller can you please review?

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #214 (3c5b018) into develop (e32f5d7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #214   +/-   ##
========================================
  Coverage    99.11%   99.12%           
========================================
  Files           14       14           
  Lines          454      456    +2     
  Branches        76       76           
========================================
+ Hits           450      452    +2     
  Misses           4        4           
Impacted Files Coverage Δ
...ular-notifier/src/lib/services/notifier.service.ts 100.00% <100.00%> (ø)

Copy link
Owner

@dominique-mueller dominique-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dominique-mueller dominique-mueller changed the title add observable actionStream Expose actionStream in Notifier Service Jul 13, 2021
@dominique-mueller dominique-mueller merged commit 881297b into dominique-mueller:develop Jul 13, 2021
@dominique-mueller
Copy link
Owner

Released with 9.1.0.

fast-facts referenced this pull request in fast-facts/angular-notifier Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants