Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOM-40084] - update python user agent #142

Merged
merged 5 commits into from
Aug 16, 2022

Conversation

ddl-olsonJD
Copy link
Contributor

@ddl-olsonJD ddl-olsonJD commented Aug 15, 2022

Link to JIRA

DOM-40084

What issue does this pull request solve?

Provide ability to track requests made through python domino

What is the solution?

Updated User-agent to python-domino-api

Testing

Insure all test continue to pass, and logs show up in New Relics

Pull Request Reminders

References (optional)

@ddl-olsonJD
Copy link
Contributor Author

Screen Shot 2022-08-15 at 14 45 57

@ddl-olsonJD ddl-olsonJD marked this pull request as ready for review August 15, 2022 21:46
@ddl-olsonJD ddl-olsonJD requested a review from a team August 15, 2022 21:46
@ddl-alexpanin
Copy link
Contributor

@dmitriyvolk do you know if setting User-Agent is safe enough or could break some scenarios where it will be overridden?

@dmitriyvolk
Copy link

I would strongly suggest adding a version string to the User-Agent

@ddl-olsonJD ddl-olsonJD merged commit 9dad759 into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants