Deprecate blobs_get and open blobs_get_v2 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-giuliocapolino
force-pushed
the
ddl-giuliocapolino.blob-get-deprecation
branch
from
11840b4
to
9a3998b
Compare
ddl-giuliocapolino
force-pushed
the
ddl-giuliocapolino.blob-get-deprecation
branch
from
9a3998b
to
a8ed6fc
Compare
domino/routes.py
Outdated
| def blobs_get(self, key): | ||
| return self._build_project_url() + "/blobs/" + key | ||
|
|
||
| def blobs_get_v2(self, path, commit_id, project_id): | ||
| return self.host + f"/api/projects/beta/projects/{project_id}/files/{commit_id}/{path}/content" |
There was a problem hiding this comment.
should this be /v1/ instead of /beta/?
There was a problem hiding this comment.
ahh good catch! yes once I merge in the other PR I will change this to it
ddl-giuliocapolino
force-pushed
the
ddl-giuliocapolino.blob-get-deprecation
branch
from
0956e72
to
6a8a10b
Compare
| @@ -69,7 +69,7 @@ def download_results(domino, commitId, results, output, exp): | |||
| output = "" | |||
|
|
|||
| for d in download: | |||
| url = domino.blobs_get(d["key"]) | |||
| url = domino.blobs_get_v2(d["path"], commitId, domino.project_id) | |||
There was a problem hiding this comment.
tested this and works as expected!
| @@ -1203,6 +1217,17 @@ def _validate_blob_key(key): | |||
| ) | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _validate_blob_path(path): | |||
There was a problem hiding this comment.
would love some test and a docstring explaining what this does?
There was a problem hiding this comment.
added! :)
ddl-gabrielhaim
approved these changes
Nov 27, 2023
|
Looks good. Update the changelog with the changes. |
ddl-olsonJD
approved these changes
Nov 28, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOM-51572
What issue does this pull request solve?
blobs_get needs to be deprecated in favor of a more secure endpoint. This will not need to go in 5.9 - so the PR will stay open for some time.
What is the solution?
deprecate it and add new endpoint!
Testing
Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.
e.g. "I ran an upgrade from 4.2 to 4.6".
Pull Request Reminders
References (optional)