-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOM-58567] Datasets Snapshot File Upload: Handle Windows-style Paths #203
Merged
ddl-eric-jin
merged 10 commits into
master
from
ddl-eric-jin.DOM-58567.fe-single-file-dataset-download-fix
Jul 2, 2024
Merged
[DOM-58567] Datasets Snapshot File Upload: Handle Windows-style Paths #203
ddl-eric-jin
merged 10 commits into
master
from
ddl-eric-jin.DOM-58567.fe-single-file-dataset-download-fix
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-giuliocapolino
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting - i’d have assumed that os.path.relpath would use os.path under the hood. but LGTM!
Please update change logs, and complete the |
ddl-olsonJD
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOM-59086
What issue does this pull request solve?
Uploading files to a Dataset on a windows can fail since the upload API expects a Unix-style filepath. The backslash will be interpreted as an escape character.
What is the solution?
When running
python-domino
on windows, transform the path to a Unix-style path, which the API to send an upload chunk for Datasets expects.Testing
Tested
domino.datasets_upload_files
for a file located at "\test\test.txt" and added unit tests.Pull Request Reminders