Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to cancel following on map drag #22

Closed
wants to merge 7 commits into from
Closed

Add option to cancel following on map drag #22

wants to merge 7 commits into from

Conversation

radicalbiscuit
Copy link
Contributor

I've added an option, cancelFollow, to cancel following when the map is dragged if follow is set to true.

@domoritz
Copy link
Owner

@radicalbiscuit This is a super useful feature. However, we need visibility of system status to show users what's happening. Could you add another state to the control to indicate that the map follows the user. So we would have requesting, active and following. I'd suggest we have an indicator like the active one (with the blue dot) but with an orange dot. I can create the image, if you are willing to write the code that adds and removes the class.

@domoritz
Copy link
Owner

Oh and can we rename the option to stopFollowingOnDrag to make it more clear what it does?

@radicalbiscuit
Copy link
Contributor Author

No problems. I'd like to take a shot at the images too, if you don't mind. Give me a little bit and I should be done with the updates.

@radicalbiscuit
Copy link
Contributor Author

Okay, take a look and let me know if I went overboard.

@domoritz
Copy link
Owner

Hey, thanks for your work. I fixed a few minor things and recreated the image from the svg.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants