build: Detect and allow external tinyxpath library usage #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Cronenworth <mike@cchtml.com>
|
Thanks! |
|
Unfortunately this is not working with the current cmake version on raspberry and other systems (for example my pine64) CMake Error at CMakeLists.txt:528 (target_sources): Current cmake version 3.0.2 |
gizmocuz
added a commit
that referenced
this pull request
Aug 12, 2017
|
I reverted it partly, most is still there, but at least it now compiles on these arm systems |
|
The target_sources command first appeared in CMake 3.1 3 years ago. The most important part of this pull request were the CMake changes. Version 3.6.2 is available in backports to you. I'd highly recommend upgrading to a newer CMake. It will prevent future development more often the longer you stay on an ancient version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines all previous work from PR 1731 into one clean commit.