Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-align:center not working for child elements with display:inline-block #1761

Closed
ThomasLandauer opened this issue Jun 20, 2018 · 11 comments · Fixed by #2505
Closed

text-align:center not working for child elements with display:inline-block #1761

ThomasLandauer opened this issue Jun 20, 2018 · 11 comments · Fixed by #2505

Comments

@ThomasLandauer
Copy link
Contributor

This is probably the same bug as #1635 but without any overhead.

Sample code:

<div style="text-align:center"><div style="display:inline-block">foo</div></div>

Expected result (as shown in Firefox & Chrome):
"foo" is centered on the page.

Actual result in dompdf 0.8.2:
"foo" is aligned to the left.

@karlmacz-08
Copy link

I'm also using version 0.8.2. Tried aligning an inline-block child element to either center or right and it doesn't seem work.

HTML

<div class="main-title">
  <div class="content">Reservation Report</div>
</div>

CSS

.main-title {
  display: block;
  text-align: right; /* text-align: center; doesn't work also. */
}

.main-title > .content {
  display: inline-block;
}

I also noticed that using text-align on the parent element only affects the text inside the child element and not the position of its child element. You can check this by giving the child element a width (Example: width: 50%;)

@bsweeney bsweeney added this to the dompdf-next milestone Dec 29, 2018
@maikealame
Copy link

Any news? This issue is very problematic for me, here my code:

<div style="display:block; position: absolute; left: ?px; top: ?px;
                   width: ?px; height: ?px;
                   overflow: hidden;">
    <div style="text-align: center; vertical-align: middle;
                       width: ?px; height: ?px; display: block;">
        @foreach( ... )
            <a href="?"
                 style="display: inline-block; border:1px solid greenyellow;
                            vertical-align: middle; margin: 10px;">
                <img src="?" style="width: ?px; height: ?px;"
                />
           </a>
        @endforeach
    </div>
</div>

@bsweeney bsweeney modified the milestones: dompdf-next, 0.8.4 May 11, 2019
@bsweeney
Copy link
Member

No news yet. I have been looking at some layout issues for the next release, so ... maybe.

@maliabdulwahed
Copy link

do it with html align="right"

@ibrghoutn
Copy link

i had this problem before and i solve it with this
i put my text on <p style="text-align: center">Hello world</P>
and it works for Me.

@bsweeney bsweeney modified the milestones: 0.8.4, dompdf-next Jan 2, 2020
@kaamui
Copy link

kaamui commented Nov 10, 2020

I face the same issue using 0.8.5 version. Could you plan to look at it for a future release ?

@artifex-media
Copy link

Same issue here, would be nice to get it fixed after 1.5 years :(

@NeekoDev
Copy link

NeekoDev commented Jul 9, 2021

3 Years now ?

Mellthas added a commit to Mellthas/dompdf that referenced this issue Aug 1, 2021
This notably adds support for inline-block.

Fixes dompdf#1761
@bsweeney bsweeney modified the milestones: dompdf-next, 1.1.0 Sep 8, 2021
Mellthas added a commit to Mellthas/dompdf that referenced this issue Sep 9, 2021
This notably adds support for inline-block.

Fixes dompdf#1761
bsweeney pushed a commit that referenced this issue Sep 10, 2021
This notably adds support for inline-block.

Fixes #1761
liam-milbel added a commit to Milestone-Belanova/dompdf that referenced this issue Sep 16, 2021
* Moving the PDF version to a `const`

* Remove unused import

* Coding standards: Enable more PSR-2 rules

Enable rules which should be uncontroversial and easy to fix.

* Apply coding-standards changes to files

* Travis: Also check tests dir for coding standards

* Update IMagick version check logic

fixes dompdf#1296

* Fix scoping issue for IMagick version check

* fix Trying to access array offset on value of type null (dompdf#2227)

* fix Trying to access array offset on value of type null

* space

* fix css selector issue

* Fall back to decimals for roman numerals, if out of range

Consistent with how web browsers do it.

See https://en.wikipedia.org/wiki/Roman_numerals#Standard_form

* Stylesheet: Rename and document `_image` method for clarity

* Stylesheet: Make `resolve_url` public to reduce code duplication

* FontMetrics: Fix text-width calculations when using different backends

Fixes issue dompdf#2403.

* FontMetrics: Use direct access for protected properties

* Extend tests for resolving URLs in stylesheets

Without `$sheet->set_base_path(__DIR__)`, the stylesheet location would
be the location of phpunit.

* Fix instantiating CPDF Adapter without Dompdf

* Avoid offset error in CPDF line trasparency logic

related to dompdf#2227

* Use strict comparison in CPDF transparency logic

* Stylesheet: Improve return-value check

* Remove temporary file created when caching an image. (dompdf#2411)

* Remove temporary file created when caching an image.
dompdf#2377

* move unlink() to exception catch block

* Fix text-width calulation with letter spacing (dompdf#2414)

* Consistent doc for `get_text_width` arguments

To clear up the confusion about whether word and char spacing can be
float.

* CPDF: Fix text-width calulation with letter spacing

The letter spacing was counted twice for every space character.

* PDFLib: Fix text-width calculation with letter spacing

See discussion in dompdf#2414.

* Use OS-indepenent file path for unit test

* BlockFrameReflower: Always resolve `auto` widths

* Fix undefined variable (dompdf#2466)

* Bump version to 0.8.6

* Reset version string to commit hash

* Bump version to 1.0.1

* Reset version string to commit hash

* Bump version to 1.0.2

* Reset version string to commit hash

* Fix undefined variable

* Fix indentation

* Fix undefined variable

* Update src/FontMetrics.php

* Update src/FontMetrics.php

Co-authored-by: Brian Sweeney <brian@eclecticgeek.com>

* Add support for `page-break-before/-after` on table rows

pr dompdf#2512:

* Fix some typos

* Update documentation text for `_page_break_allowed`

Mainly to clear up a few unclear points that have changed. The comment
about table headers does not apply anymore.

* Add support for `page-break-before/-after` on table rows

Caveat: `page-break-after: always` does not work if the row is the last
of its table row group. I want to keep things simple now; this might be
better fixed in a proper rework of the page-break-properties handling,
e.g. by properly propagating the property values as per
https://www.w3.org/TR/css-break-3/#break-propagation.

Fixes dompdf#329

* BlockFrameReflower: Fixes to height calculations (dompdf#2511)

Brings the code closer to the spec:
* Always resolve `auto` heights
* Apply `min-/max-height` independently of the `overflow` property
value
* `min-height` overrules `max-height` (swapping removed)

* Prevent case exception in text renderer (dompdf#2423)

In case of " auto " width is throws an error as following and breaks the PDF render.
ErrorException: A non-numeric value encountered in /Path_To_Project/vendor/dompdf/dompdf/src/Renderer/Text.php:158

type casting the $width to float will prevent the ErrorException

* Resolve auto margins in more cases (dompdf#2531)

Fixes dompdf#1482

* Properly skip checking for page breaks on empty text nodes (dompdf#2506)

Before, page breaks before empty text nodes were not allowed, but they
were still checked; and as they report their line height as the space
needed, they could force a page break, which then would continue to
search backwards in the tree for an element that allowed a page break
(even though it would fit on the current page).

Based on work in dompdf#1356
Fixes dompdf#2468

* Fix table column widths after page break (dompdf#2502)

Node attributes are always string, so when a table was laid out, and
then a page break occurred before the table at a later point, `$colspan`
and `$rowspan` would always be string values and fail the checks below,
most notably the check where the minimum column width is set, so that
all columns received `0` minimum width.

Fixes dompdf#2395

* Add support for any inline-positioned frames in text alignment

This notably adds support for inline-block.

Fixes dompdf#1761

* Fix `justify` text alignment with letter spacing

The old logic seemed to correct for wrong text-width calculation
involving letter spacing when using the CPDF backend. With the fix in
dompdf#2414 this is no longer needed.

* Improve support for relative positioning

* Move handling of relative positioning to after the reflow process, so
that it does not affect layout.
* Handle `right` and `bottom` properties plus `auto` values (except for
RTL language support, which is an easy FIXME).
* As a side-effet, this adds support for relative positioning on inline
and inline-block elements.

Fixes dompdf#516

* Fix logic error in `add_frame_to_line` function

The block must check its own content-box width, not the content-box
width of its containing block when placing child frames.

Fixes dompdf#2476.

* Apply line shift to justified lines with break

* Tweak Style border/outline method color handling

fixes dompdf#2367

* BlockFrameReflower: Fix handling of `100%` width

The condition is wrong, as an `auto` width can resolve to more than
100% if the minimum width of the content is larger.

* BlockFrameReflower: Remove swapping of `min-/max-width`

Per spec, `min-width` overrules `max-width`.

https://www.w3.org/TR/CSS21/visudet.html#min-max-widths

* Remove erroneous ‘degenerate’ case handling in `get_min_max_width`

If the frame has no children, it might still have a fixed width set.

Fixes dompdf#2366

* Small code cleanups (dompdf#2547)

* Clean up `get_margin_height/width` functions

For simplicity, return a `float` value consistently.
The `get_break_margins` method was unused.

* TextReflower: Small cleanup for `get_min_max_width`

Also, add type declarations to `_collapse_white_space`.

* Clean up `split` method signatures

Consistent argument names and more type declarations.

Co-authored-by: Thomas Landauer <thomas@landauer.at>
Co-authored-by: Till Berger <till@mellthas.de>
Co-authored-by: Brian Sweeney <brian@eclecticgeek.com>
Co-authored-by: Edwin Manuel Cerrón Angeles <xerron.angels@gmail.com>
Co-authored-by: Ion Bazan <ion.bazan@gmail.com>
Co-authored-by: bradbulger <1234634+bradbulger@users.noreply.github.com>
Co-authored-by: Jáchym Toušek <enumag@gmail.com>
Co-authored-by: Madi <mudasser.ismail@gmail.com>
@Rybitic
Copy link

Rybitic commented Mar 16, 2022

4 Year No Update?

@Mellthas
Copy link
Member

See the linked PR, support for this is available since 1.1.0.

@PremMallela
Copy link

5 succesfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.