Auto-width calculation, and other related bootstrap improvements #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Auto-width calculation for floated and inline-block elements. * Fix style specificity based on the origin of the stylesheet. * Add :focus psudo-class to stylesheet parser. * Modify default UA stylesheet to reflect auto-width changes. * Fix 'content' css property being set to 'normal' for all :before/:after selectors before determining their specificity. * Add extra check to prevent Helpers::build_url() from throwing a warning for URIs of 1 character (eg: '#').
|
Very nice! The changes do not appear to be so complex that it will be a problem to review as a single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap Improvements:
Visually improves the usability of bootstrap (and most likely any other inline-block/float heavy CSS) substantially. Included PDF examples of the documentation both pre and post changes (see below).
Auto-width appears to work OK based on my testing so far, any feedback on the implementation is welcome.
Included quite a few changes in this PR, if you would prefer these (or some of) individually I can split them up.
badges-pre-changes.pdf
buttons-pre-changes.pdf
buttons-post-changes.pdf
badges-post-changes.pdf