Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of issues with table-cells #1161

Closed
wants to merge 1 commit into from
Closed

Fix a couple of issues with table-cells #1161

wants to merge 1 commit into from

Conversation

scotteh
Copy link
Contributor

@scotteh scotteh commented Mar 31, 2016

Fix a couple of issues with table-cells:

  • Table-row will now ignore :before/:after frames and not include them as cells.
  • Text frames between a closing tag and opening tag will no longer be added as a table-cell. Fixes a potential issue with the getAttribute() method not existing in \DOMText.

Fixes tables in bootstrap, and also most likely fixes #1103.

 * Table-cell will now ignore :before/:after frames and not include them as cells.
 * Text frames between a </tr> closing tag and <td> opening tag will no longer be added as a table-cell. Fixes a potential issue with the getAttribute() method not existing in \DOMText.
@scotteh
Copy link
Contributor Author

scotteh commented Mar 31, 2016

Text between closing / opening tags should hopefully fix #1129.

@bsweeney bsweeney added this to the 0.7.0 milestone Apr 3, 2016
@bsweeney bsweeney closed this in 9af6eab Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First table cell misalignment
2 participants