Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SVG status #2136

Merged
merged 2 commits into from Jun 8, 2020
Merged

Document SVG status #2136

merged 2 commits into from Jun 8, 2020

Conversation

ThomasLandauer
Copy link
Contributor

Considering the SVG-related issues (#320 , #1225 , #1910 ), I thought it's about time to document the status :-)

BTW: When you're saying "Basic SVG support" (at "Features") - what else does "Basic" refer to? Are there other limitations?

@ThomasLandauer
Document SVG status
145b1bf 
Considering the SVG-related issues (#320 , #1225 , #1910 ), I thought it's about time to document the status :-)

BTW: When you're saying "Basic SVG support" (at "Features") - what else does "Basic" refer to? Are there other limitations?
bsweeney
bsweeney requested changes Jun 8, 2020
View reviewed changes
Copy link
Member

@bsweeney bsweeney left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, the best person to answer the capabilities questions around SVG support would be @PhenX since he developed the functionality.

README.md Show resolved Hide resolved
ThomasLandauer
ThomasLandauer commented Jun 8, 2020
View reviewed changes
Copy link
Contributor Author

@ThomasLandauer ThomasLandauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shouldn't have clicked "Start a review" - now trying to get outta here...

README.md Show resolved Hide resolved
@bsweeney bsweeney changed the base branch from master to develop June 8, 2020 13:39
@bsweeney bsweeney merged commit 86eaff2 into dompdf:develop Jun 8, 2020
@ThomasLandauer ThomasLandauer deleted the patch-1 branch June 8, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney bsweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThomasLandauer @bsweeney