Add promises queue #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This is a good fix since it fixes Chrome on Android. Now when Chrome connects, it can sync the state of the UI to the peripheral. Can you explain this code a bit more? Chrome on OS X & Chromebook were OK without this fix, so I'm wondering if this exposes a flaw in the Android implementation? |
|
I'm trying to document these temporary flaws at https://groups.google.com/a/chromium.org/forum/#!msg/web-bluetooth/QQP6ExsKHRI/3HLYrVpbBQAJ |
|
And see WebBluetoothCG/web-bluetooth#316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @don,
I've noticed a bug in the app that could happen when reading all characteristics at the same time. This patch adds a promises queue after
getCharacteristics.See https://googlechrome.github.io/samples/web-bluetooth/device-information-characteristics.html for the sample.
Please let me know what you think.