Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community links blocked on mobile #928

Closed
andrejewski opened this issue Apr 27, 2017 · 5 comments · Fixed by donejs/bit-docs-donejs-theme#72
Closed

Community links blocked on mobile #928

andrejewski opened this issue Apr 27, 2017 · 5 comments · Fixed by donejs/bit-docs-donejs-theme#72
Labels
bug help wanted p1 website

Comments

@andrejewski
Copy link
Contributor

On mobile, I cannot click the community links because they are covered with an invisible div:

screen shot 2017-04-27 at 1 50 02 pm

(Visible on desktop on a narrow screen.)
@chasenlehara chasenlehara mentioned this issue Nov 16, 2017
Closed
gpetrioli added a commit to gpetrioli/bit-docs-donejs-theme that referenced this issue Sep 25, 2018
@gpetrioli
Allow Community links to work on mobile
24d6fe3 
This is a fix for the donejs/donejs#928 bug.

The solution was to use a margin instead of padding so that the contain will not overlap the links.
@gpetrioli gpetrioli mentioned this issue Sep 25, 2018
Merged
@gpetrioli
Copy link

Just a note for the above PR.

The problem was not an invisible div. The overlapping element was the container of the help/upcoming/contribute links, which has a top padding. Converting that to margin and zeroing the padding pushed the container down enough to allow the links to be interactive and maintained the initial look.

@matthewp
Copy link
Contributor

Wow! Thank you for fixing this, what an awesome contribution!

@matthewp
Copy link
Contributor

Going to keep this open until we deploy the fix.

@matthewp matthewp reopened this Sep 25, 2018
@matthewp
Copy link
Contributor

This was deployed. Thanks again @gpetrioli

@justinbmeyer
Copy link
Contributor

Yes, thanks @gpetrioli !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted p1 website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow Community links to work on mobile gpetrioli/bit-docs-donejs-theme
6 participants
@justinbmeyer @matthewp @gpetrioli @andrejewski @imaustink @chasenlehara