Improve the guides #985
Merged
Improve the guides #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a note about a bug in `cordova-ios` - Fix a bunch of links (and convert them to https) - NPM -> npm - Mac OS X -> macOS
imaustink
reviewed
Jun 29, 2017
| @@ -104,7 +104,7 @@ Update `src/index.stache` to look like this: | |||
| > New APIs Used: | |||
| > - [<can-import>](https://canjs.com/doc/can-view-import.html) — specifies template dependencies. | |||
|
|
|||
| If you kept your browser window open at [http://localhost:8080/](localhost:8080) you should see the updated styles and content as soon as you save the file. | |||
| If you kept your browser window open at [http://localhost:8080/] you should see the updated styles and content as soon as you save the file. | |||
There was a problem hiding this comment.
Shouldn't this be a link?
There was a problem hiding this comment.
It is; you don’t have to include the URL if it’s the same as the link text.
| @@ -98,7 +98,7 @@ DoneJS comes with its own server, which hosts your development files and takes c | |||
| donejs develop | |||
| ``` | |||
|
|
|||
| The default port is 8080, so if we now go to [http://localhost:8080/](localhost:8080) we can see our application with a default homepage. If we change `src/index.stache` or `src/app.js` all changes will show up right away in the browser. Try it by changing the `message` property in `src/app.js`. | |||
| The default port is 8080, so if we now go to [http://localhost:8080/] we can see our application with a default homepage. If we change `src/index.stache` or `src/app.js` all changes will show up right away in the browser. Try it by changing the `message` property in `src/app.js`. | |||
| @@ -110,7 +110,8 @@ When you start Android Studio for the first time it will go through the installa | |||
|
|
|||
| Once this is complete you should have everything you need for Android development. You can close Android Studio as you won't need it for DoneJS development. | |||
|
|
|||
| ## Mac OS X | |||
| <a id="mac-os-x"></a> | |||
There was a problem hiding this comment.
The title changed, so the ID of the section changed, so this is to keep links pointing to the old section ID working.
imaustink
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cordova-ios