This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Backporting some fixes #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprovatas
reviewed
Jun 1, 2022
| @@ -341,6 +377,33 @@ void sendCGEvent(int type, int code, int value) | |||
| setModifierUp(code); | |||
| } | |||
| } | |||
| // Set the capslock modifier | |||
| if (code == KEY_CAPSLOCK) | |||
There was a problem hiding this comment.
maybe we don't need to handle it in this PR, but it would be nice to update the LED light of the caps lock button if kCGEventFlagMaskAlphaShift is in the modifiers.
Looks like this function manipulate_led might do it
cprovatas
approved these changes
Jun 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting some fixes and cleanup from @cprovatas recent fork. Thanks for the input.