Disallow peer reviewers from printing results (MarkUsProject#7114)

donny-wong · Jun 10, 2024 · d68a3de · d68a3de
1 parent 9989898
commit d68a3de
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 13 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [v2.4.11]
+
+### 🚨 Breaking changes
+
+- Disallow peer reviewers from printing results (#7114)
+
 ## [v2.4.10]
 
 ### ✨ New features and improvements

diff --git a/app/assets/javascripts/Components/Result/submission_selector.jsx b/app/assets/javascripts/Components/Result/submission_selector.jsx
@@ -102,17 +102,19 @@ export class SubmissionSelector extends React.Component {
   }
 
   renderPrintButton() {
-    return (
-      <a
-        className={"button"}
-        href={Routes.print_course_result_path(this.props.course_id, this.props.result_id)}
-        style={{alignSelf: "flex-end"}}
-        title={I18n.t("results.print")}
-      >
-        <FontAwesomeIcon icon={"fa-solid fa-print"} />
-        <span className="button-text">{I18n.t("results.print")}</span>
-      </a>
-    );
+    if (!this.props.is_reviewer) {
+      return (
+        <a
+          className={"button"}
+          href={Routes.print_course_result_path(this.props.course_id, this.props.result_id)}
+          style={{alignSelf: "flex-end"}}
+          title={I18n.t("results.print")}
+        >
+          <FontAwesomeIcon icon={"fa-solid fa-print"} />
+          <span className="button-text">{I18n.t("results.print")}</span>
+        </a>
+      );
+    }
   }
 
   onOpenFilterModal = () => {

diff --git a/app/policies/result_policy.rb b/app/policies/result_policy.rb
@@ -2,9 +2,9 @@
 class ResultPolicy < ApplicationPolicy
   default_rule :manage?
   alias_rule :get_test_runs_instructors_released?, to: :view_marks?
-  alias_rule :create?, :add_extra_mark?, :remove_extra_mark?, :get_test_runs_instructors?,
+  alias_rule :create?, :add_extra_mark?, :remove_extra_mark?, :get_test_runs_instructors?, :print?,
              :add_tag?, :remove_tag?, :revert_to_automatic_deductions?, :random_incomplete_submission?, to: :grade?
-  alias_rule :show?, :get_annotations?, :print?, to: :view?
+  alias_rule :show?, :get_annotations?, to: :view?
   alias_rule :edit?, :toggle_marking_state?, :update_overall_comment?, :next_grouping?, to: :review?
   alias_rule :refresh_view_tokens?, :update_view_token_expiry?, to: :set_released_to_students?