update to work with zig master branch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added pkg-config integration to Zig master branch to make your build script simpler. This allowed me to remove most of the hard-coded paths from build.zig. I also took advantage of `b.standardTargetOptions` and `b.setTheTarget`. This means that `zig build` will create a native executable - which will look in standard system directories for libraries - and `zig build -Dtarget=x86_64-linux-gnu` will create an executable suitable for distributing. I removed `exe.setOutputDir` and added `exe.install()`. This makes zig build do better caching (try multiple zig builds in a row after this patch), as well as be set up for doing a system install or creating a distribution, with `zig build install --prefix /your/install/path`. A default `zig build` will "install" to `zig-cache`, so for typical development purposes you would run `./zig-cache/bin/zootdeck`. The formatting changes are due to having `zig fmt` enabled on save. Hash maps are upgraded to `std.StringHashMap` to fix compilation errors. Tested with zig 53ae03ebe9e0aa56bca1c9219a47d124b0435258.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added pkg-config integration to Zig master branch to make your build
script simpler. This allowed me to remove most of the hard-coded paths
from build.zig.
I also took advantage of
b.standardTargetOptionsandb.setTheTarget.This means that
zig buildwill create a native executable - which willlook in standard system directories for libraries - and
zig build -Dtarget=x86_64-linux-gnuwill create an executable suitablefor distributing.
I removed
exe.setOutputDirand addedexe.install(). This makes zigbuild do better caching (try multiple zig builds in a row after this
patch), as well as be set up for doing a system install or creating a
distribution, with
zig build install --prefix /your/install/path.A default
zig buildwill "install" tozig-cache, so for typicaldevelopment purposes you would run
./zig-cache/bin/zootdeck.The formatting changes are due to having
zig fmtenabled on save.Hash maps are upgraded to
std.StringHashMapto fix compilation errors.Tested with zig ziglang/zig@53ae03e.