Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach main theme from dooboo-ui and maintain seperately #128

Closed
hyochan opened this issue Sep 26, 2021 · 1 comment · Fixed by #150
Closed

Detach main theme from dooboo-ui and maintain seperately #128

hyochan opened this issue Sep 26, 2021 · 1 comment · Fixed by #150

Comments

@hyochan
Copy link
Member

hyochan commented Sep 26, 2021

Previously, we deprecated @dooboo-ui/theme package and merged the theme to dooboo-ui which is the main package. The reason was that other UI frameworks also have their own ThemeProvider in their core package and we wanted to serve a similar experience to developers.

However, according to #104, and thinking further, we also want to minimize default design in separate dooboo-ui package libraries like @dooboo-ui/alert-dialog.

When trying to support the same theme to other coming package libraries, we found that we need to maintain theme in a separate package.

This can also lead to another advantage for other independent UI libraries who wish to use our theme package which is designed to support light and dark themes in default.

@hyochan hyochan added 🥺 feature request Request a new feature 🚽 migration Activities due to changes in framework 👷‍♂️ refactor and removed 🚽 migration Activities due to changes in framework labels Sep 26, 2021
@hyochan hyochan added this to the 0.2.0 milestone Sep 26, 2021
@hyochan hyochan added this to To do in Core Sep 26, 2021
@yujonglee yujonglee mentioned this issue Sep 26, 2021
3 tasks
@yujonglee yujonglee added this to Review in progress in dooboo-ui/theme Sep 27, 2021
@yujonglee yujonglee moved this from Review in progress to To do in dooboo-ui/theme Sep 27, 2021
@yujonglee yujonglee moved this from To do to In progress in dooboo-ui/theme Sep 27, 2021
@yujonglee yujonglee moved this from To do to In progress in Core Sep 27, 2021
@yujonglee
Copy link
Contributor

@dooboo-ui/theme is added, but migrating to it is not done.

@hyochan hyochan linked a pull request Oct 16, 2021 that will close this issue
2 tasks
Core automation moved this from In progress to Done Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Core
Done
dooboo-ui/theme
In progress
Development

Successfully merging a pull request may close this issue.

2 participants