-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to @dooboo-ui/theme #150
Conversation
Visit the preview URL for this PR (updated for commit f830be4): https://dooboo-ui--pr150-theme-migrate-73yrqypm.web.app (expires Sat, 30 Oct 2021 15:49:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
b7ef2f0
to
8c82d93
Compare
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 28 28
Lines 682 682
Branches 306 306
=======================================
Hits 647 647
Misses 35 35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💯
Description
This is a follow-up to the previous work #149 .
TL;DR :
@dooboo-ui/theme
works fine independently. (Link)But with something related to
build / commonjs esmodule / JSX / transpiling
, it fails to work indooboo-ui
.Currently, there's some problem that need to be fixed. Here's current status.
![스크린샷 2021-10-14 오후 10 24 31](https://user-images.githubusercontent.com/61503739/137484618-83fca3c6-8d29-473b-8cc2-739d63b1871f.png)
1.Demo
->Web
(X - build fails)iOS
(O : totally fine)Android
(Not tried but might same as iOS)2.Docs
->Only Web
(X - build complete, but component page not shown)Getting Started, Theming, Contributing works, but rest doesn't work.
3.Test
-> Fails. Can't read@dooboo-ui/theme
.Current:
When I build
@dooboo-ui/theme
with"compilerOptions": { "module": "commonjs" },
:Test Plan
None.
Related Issues
#104, #105, #129
Tests
None.
Checklist
yarn test:all
and make sure nothing fails. You can runyarn test -u
to update snapshots if needed.