Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default theme is not applied #104

Closed
yujonglee opened this issue Sep 8, 2021 · 1 comment
Closed

Default theme is not applied #104

yujonglee opened this issue Sep 8, 2021 · 1 comment
Labels
🍗 enhancement New feature or request
Projects
dooboo-ui/theme

Comments

@yujonglee
Copy link
Contributor

Default theme is not applied correctly.

See this Codesandbox and remove ThemeProvider. It is not working properly.

Although writer provided theme with default prop / value, it is not applied.
@yujonglee yujonglee mentioned this issue Sep 8, 2021
Merged
4 tasks
@hyochan hyochan added the 🍗 enhancement New feature or request label Sep 8, 2021
@yujonglee yujonglee added this to To do in dooboo-ui/theme Sep 23, 2021
@hyochan hyochan mentioned this issue Sep 26, 2021
Closed
@hyochan
Copy link
Member

hyochan commented Sep 26, 2021

I think this context is a bit different but #128 can cover this part either. Let's keep up all threads in #128.

@hyochan hyochan closed this as completed Sep 26, 2021
dooboo-ui/theme automation moved this from To do to Done Sep 26, 2021
This was referenced Oct 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍗 enhancement New feature or request
Projects
No open projects
dooboo-ui/theme
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hyochan @yujonglee