Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

[Feature Request] Add [PinchZoomView] with full screen #41

Closed
4 tasks
hyochan opened this issue Oct 30, 2019 · 6 comments
Closed
4 tasks

[Feature Request] Add [PinchZoomView] with full screen #41

hyochan opened this issue Oct 30, 2019 · 6 comments
Assignees

Comments

@hyochan
Copy link
Member

hyochan commented Oct 30, 2019

Add [PinchZoomView] with full screen to show image in full screen with pinch zoom ability.

  • Design below screen
    image
    • Image should be pinch zoomed.
    • Image area should be implemented in shared component named [PinchZoomView] or [PinchZoomHorizontalScrollView]. Imagine that this will be ported to @dooboo-ui/native.
    • bonus: Image should be carousel. left right scroll by screen.
@hyochan
Copy link
Member Author

hyochan commented Oct 30, 2019

FYI react-native-image-zoom-viewer

@JeffGuKang
Copy link
Contributor

Me -0-/

@hyochan hyochan added this to the Beta Release milestone Nov 1, 2019
@JeffGuKang
Copy link
Contributor

JeffGuKang commented Nov 12, 2019

image

I am not sure I need to apply styled-component's theme to [PinchZoomView] component. What do you think about white background?

@hyochan
Copy link
Member Author

hyochan commented Nov 14, 2019

@JeffGuKang If this is shared component, we aren't thinking about putting theme.

@JeffGuKang
Copy link
Contributor

@hyochan Okay. I will try keep the style as your example.

@hyochan
Copy link
Member Author

hyochan commented Nov 14, 2019

@JeffGuKang Try to pass down the style props.

@hyochan hyochan changed the title feat: Add [PinchZoomView] with full screen [Feature Request] Add [PinchZoomView] with full screen Nov 19, 2019
JeffGuKang added a commit to JeffGuKang/hackatalk-mobile that referenced this issue Nov 23, 2019
hyochan pushed a commit to JeffGuKang/hackatalk-mobile that referenced this issue Dec 7, 2019
@hyochan hyochan closed this as completed Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants