Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Migrate subscription to graphql-ws #557

Merged
merged 5 commits into from
Jun 3, 2022
Merged

Migrate subscription to graphql-ws #557

merged 5 commits into from
Jun 3, 2022

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Jun 2, 2022

Specify project

Both

Description

graphql-subscription-ws has been deprecated and should be migrated to graphql-ws.

Related Issues

N/A

Tests

To not fail

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added the 🚽 migration Activities due to changes in framework label Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #557 (3429718) into main (b6c829c) will decrease coverage by 0.72%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   72.30%   71.58%   -0.73%     
==========================================
  Files          65       65              
  Lines        1307     1309       +2     
  Branches      160      161       +1     
==========================================
- Hits          945      937       -8     
- Misses        335      346      +11     
+ Partials       27       26       -1     
Flag Coverage Δ
unittests 71.58% <71.42%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/src/context.ts 70.14% <66.66%> (-6.78%) ⬇️
server/src/server.ts 89.47% <80.00%> (+2.63%) ⬆️
server/src/resolvers/Upload/mutation.ts 40.00% <0.00%> (-60.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68bbf9...3429718. Read the comment docs.

@hyochan hyochan merged commit a7bca73 into main Jun 3, 2022
@hyochan hyochan deleted the migration/graphql-ws branch June 3, 2022 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚽 migration Activities due to changes in framework ☁️ server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant