Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Migrate client subscription-transport-ws to graphql-ws #558

Merged
merged 6 commits into from
Jun 3, 2022

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Jun 3, 2022

Specify project

client

Description

Migrate client subscription-transport-ws to graphql-ws.
Follow up from #557

Related Issues

N/A

Tests

To not fail

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added 🚽 migration Activities due to changes in framework 🧪 test Issue or pr related to testing 📱 client labels Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #558 (5930d63) into main (a7bca73) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5930d63 differs from pull request most recent head 274ddd5. Consider uploading reports for the commit 274ddd5 to get more accurate results

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   71.58%   71.58%           
=======================================
  Files          65       65           
  Lines        1309     1309           
  Branches      161      161           
=======================================
  Hits          937      937           
  Misses        346      346           
  Partials       26       26           
Flag Coverage Δ
unittests 71.58% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tests/testUtils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bca73...274ddd5. Read the comment docs.

@hyochan hyochan merged commit ec9167f into main Jun 3, 2022
@hyochan hyochan deleted the migration/client-graphq-ws branch June 3, 2022 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📱 client 🚽 migration Activities due to changes in framework 🧪 test Issue or pr related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant