Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to purchase more than 1 of the same consumable? #231

Closed
lefoy opened this issue Aug 14, 2018 · 5 comments
Closed

Possibility to purchase more than 1 of the same consumable? #231

lefoy opened this issue Aug 14, 2018 · 5 comments
Labels
1️⃣ good first issue Good for newcomers 🍗 enhancement New feature or request

Comments

@lefoy
Copy link
Contributor

lefoy commented Aug 14, 2018

Do you think it would be possible to implement the quantity property for iOS? I need to be able to purchase the same product multiple time.

https://developer.apple.com/documentation/storekit/skmutablepayment/1506170-quantity

Thank you!

@hyochan hyochan added 🍗 enhancement New feature or request 1️⃣ good first issue Good for newcomers labels Aug 14, 2018
@hyochan
Copy link
Member

hyochan commented Aug 14, 2018

@lefoy If you find same funtionality in android, I'd consider this in next update.

@lefoy
Copy link
Contributor Author

lefoy commented Aug 14, 2018

Unfortunately we didn't find the same functionality on Android :(

Maybe we could add a parameter to the buyProduct function and do nothing with it on Android? I know it's a bit counter intuitive but it would be a great addition for iOS.

The other plugin we were using for IAP is having some issues so we are thinking about switching to this plugin instead. The quantity parameter is very important for our app so we might have to add the functionality in our forked branch, but if we can find a way to implement it to this library, it would be best.

Here's the commit where we added the quantity parameter to the current plugin we are using. exposio/react-native-in-app-utils@af5d860

As you can see it's not a big change so I wouldn't mind working on a PR, but given the fact that such functionality doesn't exist on Android, I'm not sure how to add it to this library. Currently we are using different products to achieve the same functionality on Android (com.xxxx.product1, com.xxxx.product2, com.xxxx.product3...)

Thank you for your quick replies, have a great day

@hyochan
Copy link
Member

hyochan commented Aug 14, 2018

@lefoy Thanks. If you desperately need this feature, I'd request you to implement buyProductWithQuantityIOS to make sure that it only works in ios. PR will be good. Please follow the CONTRIBUTING.md which will remind you to fix the readme and index.d.ts.

@hyochan
Copy link
Member

hyochan commented Aug 17, 2018

PR merged.

@hyochan hyochan closed this as completed Aug 17, 2018
@ningacoding
Copy link

on Andtroid it's posible but not implemented yet. any update?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ good first issue Good for newcomers 🍗 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants