feat: improve compilation options #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiler threads may be changed in the `Advanced->Compiler Threads` menu. Defaults to the available cores - 1, but may be adjusted from 1 to maximum cores. Compiler threads also have been changed to `background` priority to prevent lock ups on start.
Switch to BS:thread_pool to abstract thread management and avoid overhead of killing and starting threads. Instead, only add jobs to pool when the number of active and queued threads is less than the limit. The reason it's total and not just active is to avoid the case where all tasks are dumped into the thread pool since the thread pool is at the hardware maximum. During compilation, one manager job is spawned to handle task allocation and the remaining threads do the compilation work.
Users can now skip shader compilation before it is finished. Shader compilation will continue using backgroundCompilationThread setting. Users are also warned that this can result in visual errors or stuttering while shaders are compiling.
doodlum
pushed a commit
that referenced
this pull request
Sep 24, 2023
* feat: allow adjustment of compiler threads Compiler threads may be changed in the `Advanced->Compiler Threads` menu. Defaults to the available cores - 1, but may be adjusted from 1 to maximum cores. Compiler threads also have been changed to `background` priority to prevent lock ups on start. * fix: fix ctd when terminating compiler threads Switch to BS:thread_pool to abstract thread management and avoid overhead of killing and starting threads. Instead, only add jobs to pool when the number of active and queued threads is less than the limit. The reason it's total and not just active is to avoid the case where all tasks are dumped into the thread pool since the thread pool is at the hardware maximum. During compilation, one manager job is spawned to handle task allocation and the remaining threads do the compilation work. * feat: enable skipping startup shader compilation Users can now skip shader compilation before it is finished. Shader compilation will continue using backgroundCompilationThread setting. Users are also warned that this can result in visual errors or stuttering while shaders are compiling.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler threads may be changed in the
Advanced->Compiler Threadsmenu. Defaults to the available cores - 1, but may be adjusted from 1 to
maximum cores. Compiler threads also have been changed to
backgroundpriority to prevent lock ups on start.
Switch to BS:thread_pool to abstract thread management and avoid
overhead of killing and starting threads. Instead, only add jobs to
pool when the number of active and queued threads is less than the
limit. The reason it's total and not just active is to avoid the case
where all tasks are dumped into the thread pool since the thread pool is
at the hardware maximum.
During compilation, one manager job is spawned to handle task
allocation and the remaining threads do the compilation work.
Users can now skip shader compilation before it is finished. Shader
compilation will continue using backgroundCompilationThread setting.
Users are also warned that this can result in visual errors or
stuttering while shaders are compiling.