refactor: move opt in for shaders to virtual feature function #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added virtual
GetShaderDefineNameto feature.h that can be overriden by each feature to specify the Shader define name for each feature.Added virtual
HasShaderDefineto feature.h to specify ifRE::BSShader::Typeis implemented by that feature, this is used in ShaderCache.cpp to know if it should add a define for each loaded featureThis PR will not require updating ShaderCache.cpp for each new/updated feature, can instead be fully controlled by the feature instead
Has tested basic functionality for each feature
Can download a release for this PR here https://github.com/FlayaN/skyrim-community-shaders/releases/tag/untagged-db023c4d6153eaa50ba7