feat: add raindrop effects, splashes and ripples to rain wetness #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pentalimbed
force-pushed
the
rain-test
branch
2 times, most recently
from
925aa22
to
eaeaa42
Compare
alandtse
reviewed
Mar 9, 2024
alandtse
previously approved these changes
Mar 10, 2024
alandtse
reviewed
Mar 10, 2024
|
Ok I forced a rebase on dev. Please confirm that didn't mess anything up for you. I'll test now since we did have some bug fixes. |
|
Ok definitely got a CTD. Looks like you need a null check (at least in VR). |
alandtse
reviewed
Mar 10, 2024
alandtse
requested changes
Mar 10, 2024
alandtse
approved these changes
Mar 11, 2024
|
Please resolve conversations for the merge to proceed. |
chore: cull dynamic cubemaps by distance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.