feat: add vr support to screen space shadows #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlayaN
force-pushed
the
screen-space-shadows-vr
branch
from
68a9ee6
to
14dc331
Compare
Closed
FlayaN
force-pushed
the
screen-space-shadows-vr
branch
2 times, most recently
from
2782389
to
baa4650
Compare
alandtse
reviewed
Mar 10, 2024
There was a problem hiding this comment.
Please address. VR only code/changes should be minimized since flat devs may see it and decide not to modify it. We already are a minority so if we diverge too much from what they're doing, we won't get new features.
That said, if there is no way to do it without code divergence, then fine.
features/Screen-Space Shadows/Shaders/ScreenSpaceShadows/RaymarchCS.hlsl
Outdated
Show resolved
Hide resolved
features/Screen-Space Shadows/Shaders/ScreenSpaceShadows/RaymarchCS.hlsl
Outdated
Show resolved
Hide resolved
FlayaN
force-pushed
the
screen-space-shadows-vr
branch
from
e2b3ba2
to
0cf20f1
Compare
--------- Co-authored-by: Andersw88 <anders.wikstrom.88@gmail.com>
FlayaN
force-pushed
the
screen-space-shadows-vr
branch
from
175dc5e
to
500f1ca
Compare
alandtse
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with @Andersw88 with some reference from @alandtse with this PR #36
Known issues / TODO: