refactor(WetnessEffects): flatten logic for clarity and maintainability #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flatten deeply nested if-statements in the Draw function. This refactor does not introduce any new functionality or performance improvements. Makes code more redable.
|
I tried to force-push a change so that the blame would be ignored for whitespaces, but git just does not allow that (because any changes to anything will always be recorded). So that is why there was an identical force-push. |
|
Thanks. Normally all PRs should be tested at least on your machine. That said, there's a proposed fix for the 1K series bug that may resolve it. https://discord.com/channels/1080142797870485606/1148180928661823488/1226040081090088982. I'll leave it to the active maintainers of wetness to provide further comments or concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flatten deeply nested if-statements in the Draw function. This refactor does not introduce any new functionality or performance improvements. Makes code more redable.
Details:
I disliked the deeply nested code which made it hard to read, so I have de-nested it somewhat. I did not make any new functions to de-nest it even further, as I do not know if that would be too much of a change. I can separate the logic into sub-functions to de-nest this even further.
Edit: I have a 1080 card, and there is a problem with the 1000 series and below, so I have not tested the code to see if it messes anything up. It really shouldn't as I have have just de-nested the logic here.