Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLF for right eye VR #58

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix LLF for right eye VR #58

merged 2 commits into from
Aug 28, 2023

Conversation

FlayaN
Copy link
Collaborator

@FlayaN FlayaN commented Aug 28, 2023

This is basically what @doodlum posted in discord for VR but simply added #if defines for VR.

Copy link
Owner

@doodlum doodlum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but I do wonder if maxPointVS and minPointVS should be checked to see if this is the optimal way to fix the clusters (min/max).

Copy link
Collaborator

@alandtse alandtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me. One small nit is if you contribute someone else's code, you should probably remember a co-author tag in the commit.

Co-authored-by: NAME NAME@EXAMPLE.COM

I'll squash and add doodles.

@alandtse alandtse merged commit c5098ac into doodlum:dev Aug 28, 2023
@FlayaN FlayaN deleted the dev-fix-llf-vr branch August 31, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants