Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add initial KickStartRT #93

Draft
wants to merge 2 commits into
base: dev-rt
Choose a base branch
from
Draft

Conversation

alandtse
Copy link
Collaborator

@alandtse alandtse commented Sep 14, 2023

Use preset ALL-RT to build.

It should build fine now with one single set local error that doesn't seem relevant.

@alandtse

This comment was marked as resolved.

@alandtse alandtse changed the base branch from dev to dev-rt September 15, 2023 04:29
@alandtse
Copy link
Collaborator Author

Looking more, it looks like most of the projects actually depend on each other. So I guess just expect a long build process.

@alandtse
Copy link
Collaborator Author

Ok fixed the include issue. Looks like there's one error related to KickstartRT_shaders because dxc has changed allowed params?

..\tools\ShaderCompiler\Release\KickstartRT_ShaderCompiler.exe --infile E:/Documents/source/repos/skyrim-community-shaders/extern/KickstartRT/shaders/shaders.cfg --parallel --out E:/Documents/source/repos/skyrim-community-shaders/build/KickstartRT/shaders/spirv --platform spirv --cflags "-Qstrip_debug -Qstrip_reflect" -I E:/Documents/source/repos/skyrim-community-shaders/extern/KickstartRT/shaders -I E:/Documents/source/repos/skyrim-community-shaders/extern/KickstartRT/thirdparty/RayTracingDenoiser/Shaders/Include -D KickstartRT_SDK_WITH_NRD=1 --compiler G:/VulkanSDK/1.3.261.1/Bin/dxc.exe --res E:/Documents/source/repos/skyrim-community-shaders/build/KickstartRT/shaders/ShaderResource_SPIRV.rc

dxc failed : -Qstrip_reflect is not supported with -spirv

I don't think it matters as CS still builds fine. Next step may be to figure out the minimum needed. Right now I took out vulkan, but for some reason we have dx12 still (which is what is pulling most of the other projects in). I'll leave it to you to figure out if we can strip it out or if it's needed in the backend anyway.

Use preset `ALL-RT` to build. This has the following issues:
* Include and src directory from KickStartRT are not in
build/KickStartRT
* Building in VS will build all subdirectores in KickStartRT even if
they are not actual dependencies of CommunityShaders. It appears the
only true dependencies are KickstartRT_Interop_D3D11 which depends on
KickstartRT_core_DX12. Those can be built successfully by selecting
Project Only build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant