Jw revoke patch #1116
Merged
Jw revoke patch #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jackvnimble . Looks good to me except the method name for |
- When revoking authorization for an application, via `AuthorizedApplicationsController#destroy` revoke `AccessToken`s and `AccessGrant`s - Update `AccessToken.revoke_all_for` specs to verify scope is respected. These specs asserted that `AccessToken.all` wasn't empty but `.all` returns tokens that are revoked and therefore the tests weren't actually verifying that the `revoke_all_for` method didn't revoke `AccessToken`s outside of the intended scope.
|
@nbulaj done. Let me know if you'd like any other changes! |
|
Thanks @jackvnimble for your work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hey folks,
Someone recently submitted an issue to my team about a security issue surrounding Doorkeeper access grants. Seems small but probably worth fixing.
The issue is that post-revocation of an access token, any access grants outstanding are still valid (until expiration which is default 10 mins). Since this code can be exchanged for an access token it should also be revoked with the other access tokens.
Notes are in the respective commits but to summarize changes:
AccessToken.revoke_all_forto ensure scope is respectedAccessGrant.revoke_all_forApplication.revoke_all_forwhich in turn callsrevoke_all_foron bothAccessGrantandAccessTokenApplication.revoke_all_forinAuthorizedApplicationsController#destroyaction