Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching of the application when custom application_class defined #1604

Merged
merged 1 commit into from Nov 29, 2022
Merged

Fix fetching of the application when custom application_class defined #1604

merged 1 commit into from Nov 29, 2022

Conversation

nbulaj
Copy link
Member

@nbulaj nbulaj commented Nov 29, 2022

Fixes #1603

@nbulaj nbulaj force-pushed the fix-issues-with-custom-app-model branch from b03c4af to 1cc879b Compare November 29, 2022 08:01
@nbulaj
Copy link
Member Author

nbulaj commented Nov 29, 2022 •
edited

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@nbulaj nbulaj force-pushed the fix-issues-with-custom-app-model branch from 2a8b318 to 5eb54be Compare November 29, 2022 08:09
@nbulaj nbulaj merged commit e520c31 into main Nov 29, 2022
@nbulaj nbulaj deleted the fix-issues-with-custom-app-model branch November 29, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.6.1 broken with custom application_class defined in devise.rb
1 participant
@nbulaj