Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uri comparing #974

Merged
merged 1 commit into from
Jan 26, 2018
Merged

Fix uri comparing #974

merged 1 commit into from
Jan 26, 2018

Conversation

dmitrytrager
Copy link
Contributor

when doing checks from authorization code request

Related to: #949

@dmitrytrager dmitrytrager mentioned this pull request Jun 9, 2017
Closed
@nbulaj
Copy link
Member

nbulaj commented Jun 16, 2017

@maclover7 I think it is ready to be merged.

@maclover7
Copy link
Member

Hi @dmitrytrager! Can you squash your commits? Other than that, looks ready to go 👍

@dmitrytrager
Copy link
Contributor Author

@maclover7 Tried to squach commit. Please, check.

@maclover7
Copy link
Member

@dmitrytrager Looks like the squash worked, but your commit message got cleared somehow. Maybe try using git commit --amend to edit it? 😬

@dmitrytrager
Copy link
Contributor Author

Hey @maclover7

This is commit I'm able to see:
commit

If you think this is not appropriate message, please, add whatever you want to this message)

@maclover7
Copy link
Member

@dmitrytrager Can you please rename the commit and its body to be more descriptive? Having # This is a combination of 3 commits. is not very informative about the changes being made 😞

@dmitrytrager
Copy link
Contributor Author

okay

@dmitrytrager
Fix uri comparing
df6ddc9 
Compare redirect_uri and grant uri without query
when doing checks from authorization code request

Fix xss by escaping tags:
content_tag body is correctly escaped when rendered even if called is
wrapped by raw

Fix CI review
@dmitrytrager
Copy link
Contributor Author

@maclover7 is it ok now?

@StupidCodeFactory
Copy link

We're getting 401's when using Doorkeeper with the omniauth gem to login which appends query params.

@maclover7 any chance to get this in?

Thanks

@nbulaj nbulaj self-requested a review January 26, 2018 15:09
@nbulaj nbulaj merged commit 2645f46 into doorkeeper-gem:master Jan 26, 2018
@nbulaj
Copy link
Member

nbulaj commented Jan 26, 2018

Thanks @dmitrytrager!

@kymmt90 kymmt90 mentioned this pull request Mar 5, 2018
Merged
@jwoudenberg jwoudenberg mentioned this pull request Mar 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj Awaiting requested review from nbulaj

Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrytrager @nbulaj @maclover7 @StupidCodeFactory