Publisher restruct #615
Merged
Publisher restruct #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trix and compile script.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #615 +/- ##
===========================================
+ Coverage 94.95% 95.48% +0.53%
===========================================
Files 36 41 +5
Lines 4853 5052 +199
Branches 930 939 +9
===========================================
+ Hits 4608 4824 +216
+ Misses 148 143 -5
+ Partials 97 85 -12 ☔ View full report in Codecov by Sentry. |
| with: | ||
| command: make test | ||
| current_path: ${{ inputs.workpath }} | ||
| attempt_limit: 3 |
There was a problem hiding this comment.
I suggest rerunning tests at the runner-level rather than restarting the whole suite.
https://pypi.org/project/pytest-rerunfailures/ could be added as a dependency in the future.
jacebrowning
approved these changes
Jan 10, 2024
This was referenced Jan 11, 2024
This was referenced Jan 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather large PR due to changes in the code structure of the publishers to make the code more maintainable, which fixes #574.
While fixing the test cases for the new structure, issues #581, #589, #601, #611 and #614 where also fixed.
Also noted that there are more python versions available, so I added 3.11 and 3.12 and they both pass all the tests so I saw no reason to remove them again.