Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Operator SDK version #953

Open
5 tasks
mateusoliveira43 opened this issue Apr 21, 2023 · 1 comment · May be fixed by #1045
Open
5 tasks

Check Operator SDK version #953

mateusoliveira43 opened this issue Apr 21, 2023 · 1 comment · May be fixed by #1045
Assignees
@mateusoliveira43
Labels
dependencies Pull requests that update a dependency file pelorus-operator

Comments

@mateusoliveira43
Copy link
Collaborator

Fix

Currently we have no check for the version of Operator SDK that creates Pelorus operator. We should not allow older versions of it to be used.

Example: Today, we use 1.28.0, so we would not be able to create new operator using Operator SDK versions 1.27.0, 1.27.1, 1.26.5, etc, but the same version, or higher, should be accepted.

requirements

  • Add safety check to create operator script
    • test that older versions are not allowed
    • test that same version is allowed
    • test that higher versions are allowed
  • OPTIONAL create a CI job that suggest bumping Operator SDK version
@mateusoliveira43 mateusoliveira43 added pelorus-operator dependencies Pull requests that update a dependency file labels Apr 21, 2023
@mpryc
Copy link
Collaborator

mpryc commented Apr 25, 2023

There is also related issue, which confirms that we can't always relay on the latest tag of the operator-sdk:

operator-framework/operator-sdk#6403 (comment)

mpryc added a commit to mpryc/pelorus that referenced this issue Apr 25, 2023
@mpryc
Make sure we are downloading newest version of the dependent tools
87bba19 
Our current script does not always works as expected.

In situation where latest tag of the dependent tool is pointing to the
lower version then the newest one, the latest will be used.

This modifies to incorporate semver checking of all the released
versions and picking up the newest one (highest semver).

Related issue: operator-framework/operator-sdk#6403
Related issue: dora-metrics#953

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@mpryc mpryc mentioned this issue Apr 25, 2023
Merged
mpryc added a commit to mpryc/pelorus that referenced this issue Apr 25, 2023
@mpryc
Make sure we are downloading newest version of the dependent tools
cfe22e5 
Our current script does not always works as expected.

In situation where latest tag of the dependent tool is pointing to the
lower version then the newest one, the latest will be used.

This modifies to incorporate semver checking of all the released
versions and picking up the newest one (highest semver).

Related issue: operator-framework/operator-sdk#6403
Related issue: dora-metrics#953

Signed-off-by: Michal Pryc <mpryc@redhat.com>
mpryc added a commit to mpryc/pelorus that referenced this issue Apr 25, 2023
@mpryc
Make sure we are downloading newest version of the dependent tools
4124ebf 
Our current script does not always works as expected.

In situation where latest tag of the dependent tool is pointing to the
lower version then the newest one, the latest will be used.

This modifies to incorporate semver checking of all the released
versions and picking up the newest one (highest semver).

Related issue: operator-framework/operator-sdk#6403
Related issue: dora-metrics#953

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@mateusoliveira43 mateusoliveira43 mentioned this issue Jul 10, 2023
Merged
1 task
@mateusoliveira43 mateusoliveira43 self-assigned this Aug 5, 2023
@mateusoliveira43 mateusoliveira43 linked a pull request Aug 9, 2023 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateusoliveira43 mateusoliveira43

Labels
dependencies Pull requests that update a dependency file pelorus-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve operator development steps dora-metrics/pelorus
2 participants
@mpryc @mateusoliveira43