New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve operator development steps #1045
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if configmaps and secrets are not used and update docs to point to new helm-charts location
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just example of file generated by new script, this file will be deleted prior to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirm that change did not modified operator image
@@ -47,7 +47,7 @@ | ||
endif | ||
@@ -51,7 +51,7 @@ | ||
OPERATOR_SDK_VERSION ?= v1.31.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works if newest Operator SDK version, 1.31.0, but because of the change, it would need to be updated every time we update its version
My idea is delete this folder, but want opinions
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove this change from Makefile in operator folder
Add it to Makefile in project root, do not change generated code
Linked Issues
resolves #953
resolves #970
related to #1032
related to #884
Description
Testing Instructions
TODO
Operator SDK update
For example, run
./scripts/update_operator_sdk_version.py v1.31.0 # check script logs patch -p1 --verbose -d pelorus-operator -i current-to-next.diff
Project versions
Just removed
-f
and-d
flags from script. The big difference is for updating operator CRD, you now update a yaml file instaed of a diff file, for example.