Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure additional config options are used by the Pelorus #861

Closed
wants to merge 1 commit into from
Closed

Ensure additional config options are used by the Pelorus #861

wants to merge 1 commit into from

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented Mar 6, 2023

This adds an option to the CRD which preserves the config options which are additional to the ones we define in the openapi schema. This option is already existing for the exporters but was missing for the top level configs.

@redhat-cop/mdt

@mpryc
Ensure additional config options are used by the Pelorus
7dcc3e2 
This adds an option to the CRD which preserves the config
options which are additional to the ones we define in the
openapi schema. This option is already existing for the
exporters but was missing for the top level configs.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mpryc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc mpryc mentioned this pull request Mar 6, 2023
Closed
@mpryc
Copy link
Collaborator Author

mpryc commented Mar 6, 2023

Fixes #860

@mpryc mpryc linked an issue Mar 6, 2023 that may be closed by this pull request
Config options other then specified in the open api schema are not used #860
Closed
@mateusoliveira43
Copy link
Collaborator

Why do we not fix the problem by adding the reaming fields to the operator CRD?

And can we not work with diff files for this?

@mateusoliveira43
Copy link
Collaborator

I would close this PR without merging, as another solution is proposed here #869

Or do you believe this option of letting user add any config can be useful?

@mpryc
Copy link
Collaborator Author

mpryc commented Mar 7, 2023

Closing as we agree to change the API schema to confirm with only known and supported options.

@mpryc mpryc closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusoliveira43 mateusoliveira43 Awaiting requested review from mateusoliveira43

@weshayutin weshayutin Awaiting requested review from weshayutin

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config options other then specified in the open api schema are not used
2 participants
@mpryc @mateusoliveira43