New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/operator form options #869
Fix/operator form options #869
Conversation
52b7853
to
8544b87
Compare
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
8544b87
to
23e1f26
Compare
Can the options be better grouped ? Also we need to discuss the layout before implementing them in the operator itself. Thinking here of options in the format of:
|
I do not know @mpryc , I will try out |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
I think we can not group them, but reordered them @mpryc |
How about the following top structure (and it's top-level titles):
|
The path can be used with dots, can this be used to also define exporters order? |
Can the secrets and configmaps be used similarly to this example? https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md#3-k8sresourceprefix |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
I think I addressed everything now @mpryc to test it, |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
Describe the behavior changes introduced in this PR
Allow form view to gave all fields user can have, when creating instance from Pelorus Operator.
Linked Issues
Resolves #860
Testing Instructions
Use Pelorus operator from mine quay repository
Then, create an instance of Pelorus using form or yaml view, to test if it is working. It should warn of wrong usage or lack of required fields.
To clean it up, run