Use read_line instead of next_line in stderr #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using read_line, we make stderr similar to stdout. Moreover, we can replicate the functionality in stdout in stderr and retrieve the full traceback for python nodes. This way, we can print python errors in the daemon logs without having to look at the log files.
By using cargo instead of git, we make compilation not have to git clone dora project.
…late Use cargo instead of git in Rust `Cargo.toml` template
phil-opp
approved these changes
Jul 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using read_line, we make stderr behave similarly to stdout.
stderrthat usenext_lineuse to not add newline at the end of each line which made me open #320.This made
stdoutthat useread_linehave two newlines. This was introduced here: #300This PR fix this issue.
Moreover, I have added functionality in the stderr thread to retrieve python traceback and output it as one block in the DEBUG traces but also push it as an ERROR trace in daemon so that user don't have to check log file.
This is done by replicating the functionality in stdout in stderr and retrieve the full traceback for python nodes.