Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple warning fixes #477

Merged
merged 7 commits into from
Apr 19, 2024
Merged

Simple warning fixes #477

merged 7 commits into from
Apr 19, 2024

Commits on Apr 18, 2024

  1. ros2-bridge: add feature flag to build::ament_prefix_paths 

    It's only used with the `generate-messages` feature.
    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    37fa264 View commit details
    Browse the repository at this point in the history

  2. lint: fix clippy lints

    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    dfe298e View commit details
    Browse the repository at this point in the history

  3. lint: more simple lint fixes

    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    829d30c View commit details
    Browse the repository at this point in the history

  4. warn: allow clippy::missing_safety_doc

    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7cb43ca View commit details
    Browse the repository at this point in the history

  5. lint: allow type-complexity for select signatures

    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3b59b02 View commit details
    Browse the repository at this point in the history

  6. lint: allow clippy::should_implement_trait for infallible U16String::… 

    …from_str
    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3c6204e View commit details
    Browse the repository at this point in the history

  7. refactor: format error messages without allocating a string for each … 

    …line

I added a test to confirm the output matches the old.

Fixes clippy warning clippy::format_collect
https://rust-lang.github.io/rust-clippy/master/index.html#/format_collect
    @Michael-J-Ward
    Michael-J-Ward committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ae9e19e View commit details
    Browse the repository at this point in the history