Simple warning fixes #477
Merged
Simple warning fixes #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used with the `generate-messages` feature.
|
This is useful, thanks!
That would be great! I think we can silence the "missing Safety section" warnings for now. |
…line I added a test to confirm the output matches the old. Fixes clippy warning clippy::format_collect https://rust-lang.github.io/rust-clippy/master/index.html#/format_collect
haixuanTao
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippy lights up my editor with warnings. Here are a few of the simple fixes.
If you want, I can address the rest sans the
unsafe function's docs miss #Safety sectionwarnings.