Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #208 - java-junit: show annotations on PR changed files #209

Conversation

atsu85
Copy link
Contributor

@atsu85 atsu85 commented Nov 19, 2022

Fixes #208.
Resulting screenshot of annotation added to the PR of the project that i used for testing the changes:
image

.nvmrc Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@dharmendrasha
Copy link
Collaborator

https://github.com/dorny/test-reporter/actions/runs/3505027534/jobs/5983498492

Showing me this error in the code pipeline

image

@atsu85
Copy link
Contributor Author

atsu85 commented Nov 28, 2022

Hi @dharmendrasha,
Please reopen this PR - you came to wrong conclusion from the error!

This error you pointed out was expected, because this PR was created by me and i don't have permissions for this repo (similar situation described here). However if the owner of this repo creates the PR from my commits, then this error shouldn't occur, just like it didn't occur in my fork using the same commits

@dharmendrasha
Copy link
Collaborator

Sure @atsu85 will do that

@atsu85
Copy link
Contributor Author

atsu85 commented Nov 28, 2022

@dharmendrasha , by the way the same issue is reported also in this project many times and there is even a PR (by @hungrybear88) to fix it (as claimed here by @hilmarf), but currently that PR isn't merged

@dharmendrasha dharmendrasha reopened this Nov 28, 2022
@dorny
Copy link
Owner

dorny commented Nov 29, 2022

Thanks @atsu85 ! PR looks good. I'm merging it now.
It's true the PR's from forked repos will have failed check run due to permission issues.
Shame on me, the issue and workaround are actually described in our own README.
Probably we should use that approach for the PR's and test the direct approach some other way.

@dorny dorny merged commit 8bf0c7d into dorny:main Nov 29, 2022
@atsu85 atsu85 deleted the issue-208-java-junit-show-annotations-on-pr-changed-files branch December 2, 2022 08:57
github-merge-queue bot pushed a commit to AmadeusITGroup/otter that referenced this pull request Mar 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [dorny/test-reporter](https://togithub.com/dorny/test-reporter) |
action | minor | `v1` -> `v1.8.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>dorny/test-reporter (dorny/test-reporter)</summary>

###
[`v1.8.0`](https://togithub.com/dorny/test-reporter/releases/tag/v1.8.0)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.7.0...v1.8.0)

#### What's Changed

- CHANGELOG.md by [@&#8203;j-catania](https://togithub.com/j-catania) in
[dorny/test-reporter#297
- Bump [@&#8203;babel/traverse](https://togithub.com/babel/traverse)
from 7.12.1 to 7.23.2 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#303
- Bump [@&#8203;babel/traverse](https://togithub.com/babel/traverse)
from 7.22.20 to 7.23.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#304
- Add `SwiftXunitParser` class based on `JavaJunitParser` for
`swift-xunit` reporter by
[@&#8203;jozefizso](https://togithub.com/jozefizso) in
[dorny/test-reporter#317
- Update to Node20 by
[@&#8203;j-catania](https://togithub.com/j-catania) in
[dorny/test-reporter#315
- Fix build error by [@&#8203;dorny](https://togithub.com/dorny) in
[dorny/test-reporter#331
- Use NodeJS 18 LTS as default runtime by
[@&#8203;jozefizso](https://togithub.com/jozefizso) in
[dorny/test-reporter#332
- Update all packages by
[@&#8203;jozefizso](https://togithub.com/jozefizso) in
[dorny/test-reporter#333
- Escape <> characters in suite name by
[@&#8203;wingyplus](https://togithub.com/wingyplus) in
[dorny/test-reporter#236
- Adding feature and bug template by
[@&#8203;j-catania](https://togithub.com/j-catania) in
[dorny/test-reporter#341
- Update check title and remove icon by
[@&#8203;ldaneliukas](https://togithub.com/ldaneliukas) in
[dorny/test-reporter#144
- `test-reporter` release v1.8.0 by
[@&#8203;jozefizso](https://togithub.com/jozefizso) in
[dorny/test-reporter#370

#### New Contributors

- [@&#8203;jozefizso](https://togithub.com/jozefizso) made their first
contribution in
[dorny/test-reporter#317
- [@&#8203;wingyplus](https://togithub.com/wingyplus) made their first
contribution in
[dorny/test-reporter#236
- [@&#8203;ldaneliukas](https://togithub.com/ldaneliukas) made their
first contribution in
[dorny/test-reporter#144

**Full Changelog**:
dorny/test-reporter@v1.7.0...v1.8.0

###
[`v1.7.0`](https://togithub.com/dorny/test-reporter/releases/tag/v1.7.0)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.6.0...v1.7.0)

#### What's Changed

- Fix
[#&#8203;199](https://togithub.com/dorny/test-reporter/issues/199): Use
✅ instead of ✔️ for better cross platform look by
[@&#8203;petrdvorak](https://togithub.com/petrdvorak) in
[dorny/test-reporter#200
- Verify content of dist/ folder matches build output by
[@&#8203;dorny](https://togithub.com/dorny) in
[dorny/test-reporter#207
- Gracefully handle empty nested testsuite elements for JUnit. by
[@&#8203;rvdlaarschot](https://togithub.com/rvdlaarschot) in
[dorny/test-reporter#193
- Gracefully handle empty failure tags by
[@&#8203;haudren-woven](https://togithub.com/haudren-woven) in
[dorny/test-reporter#213
- Fix [#&#8203;208](https://togithub.com/dorny/test-reporter/issues/208)
- java-junit: show annotations on PR changed files by
[@&#8203;atsu85](https://togithub.com/atsu85) in
[dorny/test-reporter#209
- Only report failure if fail-on-error is set by
[@&#8203;trond-snekvik](https://togithub.com/trond-snekvik) in
[dorny/test-reporter#214
- Improve clarity on configuring for forkable repos by
[@&#8203;abelbraaksma](https://togithub.com/abelbraaksma) in
[dorny/test-reporter#211
- Suppress "Processing test results from" log by
[@&#8203;vasanthdharmaraj](https://togithub.com/vasanthdharmaraj) in
[dorny/test-reporter#179
- Skip listing of files if error parsing is disabled by
[@&#8203;dorny](https://togithub.com/dorny) in
[dorny/test-reporter#216
- Correct typo in docs by
[@&#8203;tangowithfoxtrot](https://togithub.com/tangowithfoxtrot) in
[dorny/test-reporter#254
- update dependencies by
[@&#8203;j-catania](https://togithub.com/j-catania) in
[dorny/test-reporter#269
- Add permissions to example yml files by
[@&#8203;TurnrDev](https://togithub.com/TurnrDev) in
[dorny/test-reporter#263
- add feature fail-on-empty by
[@&#8203;gdams](https://togithub.com/gdams) in
[dorny/test-reporter#243
- Add dependabot configuration by
[@&#8203;yeikel](https://togithub.com/yeikel) in
[dorny/test-reporter#228
- Bump ws from 7.3.1 to 7.5.9 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#265
- Bump actions/checkout from 2 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#279
- Add new output for url url html by
[@&#8203;luisito666](https://togithub.com/luisito666) in
[dorny/test-reporter#242
- Update README.md by
[@&#8203;IanMoroney](https://togithub.com/IanMoroney) in
[dorny/test-reporter#158
- Update jest-Junit part of Readme by
[@&#8203;ryancasburn-KAI](https://togithub.com/ryancasburn-KAI) in
[dorny/test-reporter#176
- fix: default-valued fields are not mandatory by
[@&#8203;TomerFi](https://togithub.com/TomerFi) in
[dorny/test-reporter#172
- Bump ansi-regex from 4.1.0 to 4.1.1 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#278
- Bump decode-uri-component from 0.2.0 to 0.2.2 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#276
- Bump minimist from 1.2.5 to 1.2.8 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#275
- Bump qs from 6.5.2 to 6.5.3 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#272
- Bump json5 from 2.1.3 to 2.2.3 in /reports/jest by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#271
- Bump ansi-regex from 3.0.0 to 3.0.1 in /reports/mocha by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[dorny/test-reporter#270
- declare 'url' and 'url_html' as action outputs by
[@&#8203;micha-one](https://togithub.com/micha-one) in
[dorny/test-reporter#287
- Avoid split on undefined by
[@&#8203;cazou](https://togithub.com/cazou) in
[dorny/test-reporter#258

#### New Contributors

- [@&#8203;petrdvorak](https://togithub.com/petrdvorak) made their first
contribution in
[dorny/test-reporter#200
- [@&#8203;rvdlaarschot](https://togithub.com/rvdlaarschot) made their
first contribution in
[dorny/test-reporter#193
- [@&#8203;haudren-woven](https://togithub.com/haudren-woven) made their
first contribution in
[dorny/test-reporter#213
- [@&#8203;atsu85](https://togithub.com/atsu85) made their first
contribution in
[dorny/test-reporter#209
- [@&#8203;trond-snekvik](https://togithub.com/trond-snekvik) made their
first contribution in
[dorny/test-reporter#214
- [@&#8203;abelbraaksma](https://togithub.com/abelbraaksma) made their
first contribution in
[dorny/test-reporter#211
- [@&#8203;vasanthdharmaraj](https://togithub.com/vasanthdharmaraj) made
their first contribution in
[dorny/test-reporter#179
- [@&#8203;tangowithfoxtrot](https://togithub.com/tangowithfoxtrot) made
their first contribution in
[dorny/test-reporter#254
- [@&#8203;TurnrDev](https://togithub.com/TurnrDev) made their first
contribution in
[dorny/test-reporter#263
- [@&#8203;gdams](https://togithub.com/gdams) made their first
contribution in
[dorny/test-reporter#243
- [@&#8203;yeikel](https://togithub.com/yeikel) made their first
contribution in
[dorny/test-reporter#228
- [@&#8203;luisito666](https://togithub.com/luisito666) made their first
contribution in
[dorny/test-reporter#242
- [@&#8203;IanMoroney](https://togithub.com/IanMoroney) made their first
contribution in
[dorny/test-reporter#158
- [@&#8203;ryancasburn-KAI](https://togithub.com/ryancasburn-KAI) made
their first contribution in
[dorny/test-reporter#176
- [@&#8203;TomerFi](https://togithub.com/TomerFi) made their first
contribution in
[dorny/test-reporter#172
- [@&#8203;micha-one](https://togithub.com/micha-one) made their first
contribution in
[dorny/test-reporter#287
- [@&#8203;cazou](https://togithub.com/cazou) made their first
contribution in
[dorny/test-reporter#258

**Full Changelog**:
dorny/test-reporter@v1.6.0...v1.7.0

###
[`v1.6.0`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v160)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.5.0...v1.6.0)

- [Update to node16 + recent versions of core and exec
packages](https://togithub.com/dorny/test-reporter/pull/203)
- [Update all dependencies to latest
versions](https://togithub.com/dorny/test-reporter/pull/186)
- [Fix tests on non us-EN local
env](https://togithub.com/dorny/test-reporter/pull/185)

###
[`v1.5.0`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v150)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.4.3...v1.5.0)

- [Add option to convert backslashes in path pattern to forward
slashes](https://togithub.com/dorny/test-reporter/pull/128)
- [Add option to generate only the summary from processed test results
files](https://togithub.com/dorny/test-reporter/pull/123)

###
[`v1.4.3`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v143)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.4.2...v1.4.3)

- [Patch java-junit to handle missing time
field](https://togithub.com/dorny/test-reporter/pull/115)
- [Fix dart-json parsing broken by print
message](https://togithub.com/dorny/test-reporter/pull/114)

###
[`v1.4.2`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v142)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.4.1...v1.4.2)

- [Fix dotnet-trx parsing of passed tests with non-empty error
info](https://togithub.com/dorny/test-reporter/commit/43d89d5ee509bcef7bd0287aacc0c4a4fb9c1657)

###
[`v1.4.1`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v141)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.4.0...v1.4.1)

- [Fix dotnet-trx parsing of tests with custom display
names](https://togithub.com/dorny/test-reporter/pull/105)

###
[`v1.4.0`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v140)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.3.1...v1.4.0)

- [Add support for
mocha-json](https://togithub.com/dorny/test-reporter/pull/90)
- [Use full URL to fix navigation from summary to suite
details](https://togithub.com/dorny/test-reporter/pull/89)
- [New report rendering with code blocks instead of
tables](https://togithub.com/dorny/test-reporter/pull/88)
- [Improve test error messages from
flutter](https://togithub.com/dorny/test-reporter/pull/87)

###
[`v1.3.1`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v131)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.3.0...v1.3.1)

- [Fix: parsing of .NET duration string without
milliseconds](https://togithub.com/dorny/test-reporter/pull/84)
- [Fix: dart-json - remove group name from test case
names](https://togithub.com/dorny/test-reporter/pull/85)
- [Fix: net-trx parser crashing on missing duration
attribute](https://togithub.com/dorny/test-reporter/pull/86)

###
[`v1.3.0`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v130)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.2.0...v1.3.0)

- [Add support for
java-junit](https://togithub.com/dorny/test-reporter/pull/80)
- [Fix: Handle test reports with no test
cases](https://togithub.com/dorny/test-reporter/pull/70)
- [Fix: Reduce number of API calls to get list of files tracked by
GitHub](https://togithub.com/dorny/test-reporter/pull/69)

###
[`v1.2.0`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v120)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.1.0...v1.2.0)

- [Set `listTests` and `listSuites` to lower detail if report is too
big](https://togithub.com/dorny/test-reporter/pull/60)

###
[`v1.1.0`](https://togithub.com/dorny/test-reporter/blob/HEAD/CHANGELOG.md#v110)

[Compare
Source](https://togithub.com/dorny/test-reporter/compare/v1.0.0...v1.1.0)

- [Support public repo PR
workflow](https://togithub.com/dorny/test-reporter/pull/56)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" in timezone Europe/Paris, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/AmadeusITGroup/otter).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIzMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java-junit] show annotations on PR "Files changed" tab next to code line related to the failure
3 participants