Avoid split on undefined

[cazou]

Some reports don't include a stack trace or details on the failure.
This can happen, for example, for junit reports that are used with non Java tests or when subtests are used. See #256 #241 or #239 (there may be others)

Just ignore the stacktrace if it is not defined.

[acpbm]

Will this PR be merged any time soon?

[cazou]

@acpbm From what I see, @dorny hasn't been maintaining this since November 2022. So not sure about the status

[acpbm]

@cazou I tried out your solution (which was very reasonable) but I'm still getting the "Cannot read property 'split' of undefined" error message.

The parser the test reporter is using is java-junit (as you already mentioned), and it appears the error happens as soon as the TestReporter object calls the "this.createReport()" on line 295 on index.js file. When I use the github action in my workflow, it prints "Creating test report .." and then immediately errors out (even after avoiding split on undefined at the locations you fixed).

Any idea of any other location it may be calling split on undefined?

[acpbm]

@cazou I was finally able to get it to work.

Here is what I changed:

https://github.com/dorny/test-reporter/blob/daece3018b33d4c6311cfde77ced40c4c42effa6/dist/index.js#L1063C49-L1063C49

changed to this () based on your example:

 const lines = stackTrace === null || stackTrace === void 0? void 0 : stackTrace.split(/\r?\n/);

Added this before the for loop found here:
https://github.com/dorny/test-reporter/blob/daece3018b33d4c6311cfde77ced40c4c42effa6/dist/index.js#L1064

if (!lines) return void 0;

This worked for me but it would be nice to have the logic reviewed by a typescript/js developer.