All my changes in one PR, since I had made a mess of things - support ion, simplify logic #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dot and sourcing them, just having antidot init print all rules
…es the proper script for the shell whenever it is run
…familiar enough with go to do that
…e HISTFILE variable that ion uses too
…'t use `-c` when listing how to source the output of `antidot init` because it isn't needed
…iting without testing
…plicit `-s` option in recommendation by `antidot init`
|
@magnus-ISU thanks for the PR. I really appreciate the effort. It's been some time since I actively maintained this project but now I am back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is that this PR simplifies a lot of logic, makes the program touch less stuff / have less files that could break, resolving #162, also improves some help messages and causes antidot init to tell the user what to do with the output / how to run it. These messages explicitely say to use
-sfor fish and ion since on Garuda Linux runningfishstill keeps$SHELL == bashsomehow.Also makes it marginally easier to support new shells.
Previously antidot clean would generate ~/.local/share/antidot/kvstore.json, ~/.local/share/antidot/env.sh, and ~/.local/share/antidot/alias.sh and then antidot init would create a default script that would source those two scripts, with extra logic to test if those scripts exist and other nonsense.
Now antidot clean generates ~/.local/share/antidot/kvstore.json and antidot init creates a script based on the kvstore that creates all aliases and sources all variables.
Next, this PR adds support for the
ionshell.Additionally, this PR improves some help and error messages.
Finally, this PR adds a section to the README about how to build
antidot, and adds the binary file to the.gitignore.