Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash_reports: fix sysdiagnose complete syslog match #772

Merged

Conversation

StephenGemin
Copy link
Contributor

@StephenGemin StephenGemin commented Jan 8, 2024

Fix detecting sysdiagnose complete when triggered via accessibility icon. Both devices have similar syslog entries

SyslogEntry(
  pid=563, 
  timestamp=datetime.datetime(2024, 1, 7, 23, 22, 2, 150124), 
  level=<SyslogLogLevel.NOTICE: 0>,
  image_name='/System/Library/PrivateFrameworks/AccessibilityPhysicalInteraction.framework/AccessibilityPhysicalInteraction',
  filename='/System/Library/CoreServices/AssistiveTouch.app/assistivetouchd', 
  message='Sysdiagnose completed. File path: /private/var/mobile/Library/Logs/CrashReporter/DiagnosticLogs/sysdiagnose/sysdiagnose_2024.01.07_23-20-38-0500_iPhone-OS_iPhone_20F66.tar.gz', 
  label=SyslogLabel(category='AXPhysicalInteraction', subsystem='com.apple.Accessibility')
)

I'm wondering if the current implementation assumes sysdiagnose is triggered by pressing both volume buttons? I wasn't able to trigger sysdiagnose using that method.


Testing

syslog_files.zip

  • iphone8
    • ios16.5
  • iphone14
    • ios17.0.2

@StephenGemin StephenGemin marked this pull request as ready for review January 8, 2024 17:51
@StephenGemin StephenGemin force-pushed the bugfix/sysdiagnose-syslog-match branch from 95b943c to e6f53da Compare January 8, 2024 18:12
Copy link
Owner

@doronz88 doronz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
This project uses ' instead of " for strings. Please refactor them

tests/services/test_crash_reports.py Outdated Show resolved Hide resolved
@doronz88
Copy link
Owner

doronz88 commented Jan 9, 2024

Also, I'm triggering the sysdiagnose by pressing all the buttons for very small period of time (it's also printed from CLI)

@StephenGemin StephenGemin force-pushed the bugfix/sysdiagnose-syslog-match branch 2 times, most recently from 77a40e3 to 2198070 Compare January 9, 2024 22:57
@StephenGemin StephenGemin force-pushed the bugfix/sysdiagnose-syslog-match branch from d67507b to 9a74702 Compare January 10, 2024 00:04
@doronz88 doronz88 merged commit 6655442 into doronz88:master Jan 10, 2024
17 checks passed
@StephenGemin StephenGemin deleted the bugfix/sysdiagnose-syslog-match branch April 25, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants